TxRiakManager needs its own threadpool

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.

BSD 3-Clause "New" or "Revised" License

420 stars 131 forks source link

TxRiakManager needs its own threadpool #948

Closed jerith closed 9 years ago

jerith commented 9 years ago

It currently uses the general reactor threadpool, but we want tighter control over concurrency and we don't want to muck about with the reactor's threadpool in case other things are using it.

hodgestar commented 9 years ago

And thoughts on how we can test that the thread pool is being used where its supposed to be?

jerith commented 9 years ago

Builds failed because the threads weren't being killed and they're not daemon threads, so they block process exit.

jerith commented 9 years ago

Ready for another review.

hodgestar commented 9 years ago

:+1: