search

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.
BSD 3-Clause "New" or "Revised" License
420 stars 131 forks source link

Factor out common Riak wrapper code #956

Closed jerith closed 9 years ago

jerith commented 9 years ago

RiakManager and TxRiakManager both have a lot of wrapper code around the underlying library objects, and there's a bunch of duplication here. This issue is for factoring out the common bits and adding a new wrapper around the client object that we can add extra things to later.

(This is another case of pulling a piece of the big Riak manager cleanup/threadpool/whatever mudball out into its own smaller change.)

jerith commented 9 years ago

This is ready for review. Any suggestions for other things to factor out would also be helpful.

hodgestar commented 9 years ago

Looks sane to me. Do we want tests for things in the base classes?

jerith commented 9 years ago

We already have common tests that run across both subclasses, so I don't think tests on the base classes specifically would add much.

JayH5 commented 9 years ago

:+1: :ship: