Make SMPPs acks optional.

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.

BSD 3-Clause "New" or "Revised" License

421 stars 131 forks source link

Closed smn closed 9 years ago

smn commented 9 years ago

@jerith & @hodgestar ready for review. Test failing on real redis but I suspect that's due to me not waiting on some socket cleanup?

smn commented 9 years ago

Fixed the test with @jerith's help. Please review :)

jerith commented 9 years ago

One comment, otherwise this looks good.

hodgestar commented 9 years ago

Other than @jerith's comment, looks good to me too.

jerith commented 9 years ago

Some of the build failures are pypy 2.5.0 and cryptography. I've restarted the failed build job that wasn't.

hodgestar commented 9 years ago

All builds passed except pypy.

smn commented 9 years ago

Is that a :+1: then?

hodgestar commented 9 years ago

Yep. :+1: