search

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.
BSD 3-Clause "New" or "Revised" License
420 stars 131 forks source link

Better SMPP multipart_info handling #968

Closed jerith closed 9 years ago

jerith commented 9 years ago

At the moment, this uses the week-long third_party_id_expiry and is never cleared. Instead it should use the day-log submit_sm_expiry and be cleared after all parts of a message have been acknowledged.

(There may be some overlap with #965, but running out of memory in Redis is a worse problem than potential extra acks.)

hodgestar commented 9 years ago

Left a couple of comments, otherwise looks good.

hodgestar commented 9 years ago

:+1: once Travis is happy.