praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.
BSD 3-Clause "New" or "Revised" License
420 stars 131 forks source link

Better SMPP test machinery #970

Closed jerith closed 9 years ago

jerith commented 9 years ago

Our current SMPP transport test machinery is very ad-hoc and relies on overriding different things in different places.

This branch replaces that with a "fake SMSC" that operates exposes a Twisted endpoint the code under test can connect to.

jerith commented 9 years ago

Some of the connection machinery would be useful in other tests, but factoring that out is best left for later.

jerith commented 9 years ago

I'm going to rewrite the FakeSMSC tests to not use the things it's supposed to be testing.

JayH5 commented 9 years ago

:+1: from me although I feel a bit under-qualified :p