search

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.
BSD 3-Clause "New" or "Revised" License
420 stars 131 forks source link

Infrastructure for publishing and consuming status events #979

Closed justinvdm closed 8 years ago

justinvdm commented 8 years ago

We need a way of publishing and consuming status event messages in workers.

The plan is to add two new connector types, one for publishing status event messages and one for consuming status event messages.

justinvdm commented 8 years ago

Ready for review.

Planning on changing the base transport worker to have status event publishing capabilities in a separate PR.

hodgestar commented 8 years ago

Some minor comments, otherwise looks good.

hodgestar commented 8 years ago

I have a very bikesheddy comment -- would healthy connector be a better name than status connector? Trying to decide if it feels better enough to warrant running around and changing?

justinvdm commented 8 years ago

I have a very bikesheddy comment -- would healthy connector be a better name than status connector? Trying to decide if it feels better enough to warrant running around and changing?

Thought about this too, had a vague preference for 'health' over 'status' in general, but we already seem to refer to it as 'status' in junebug (e.g. status_url), so I think consistency would be good.

hodgestar commented 8 years ago

Cool. Let's keep it as it is.

justinvdm commented 8 years ago

Ready for re-review.

hodgestar commented 8 years ago

:+1: