search

praekeltfoundation / vumi

Messaging engine for the delivery of SMS, Star Menu and chat messages to diverse audiences in emerging markets and beyond.
BSD 3-Clause "New" or "Revised" License
420 stars 131 forks source link

Publish status event when starting for SMPP transport #989

Closed justinvdm closed 8 years ago

justinvdm commented 8 years ago

Similar to #983-#988, except for when we start connecting.

justinvdm commented 8 years ago

Publishing connecting events is going to require changing ReconnectingClientService to support hooks for when we connect. For now, I've renamed the ticket to be for publishing status events when the transport is starting. The plan is to add connect event publishing in a different PR once we are able to add hooks for when we are reconnecting.

justinvdm commented 8 years ago

Ready for review.

rudigiesler commented 8 years ago

:+1:

rudigiesler commented 8 years ago

But we must watch out for https://github.com/praekelt/vumi/pull/992 and this, we need to make sure that one lands before the other, and that the relevant changes are made in the other.

justinvdm commented 8 years ago

@rudigiesler thanks, merging in #992 and making the relevant changes. Will land once #992 lands.