Open josephwhenry opened 1 week ago
@storbeck thoughts on this topic? I see both sides.
Let's make this change and see if anybody complains about it.
My initial thoughts are that we should stay consistent with the other modals, which is to close on Escape or click-away. However, @josephwhenry is a heavy user of the application and has real-world experience and this would improve his day-to-day experience. So, I say let's change it and revisit it later if required
Feature Description Currently, the Chariot UI closes an open integration card if the user clicks outside the card. It may be better for the card to stay open until the user clicks one of the "Add/Update" or "Cancel" buttons (i.e., clicking outside the card won't do anything).
Problem Personally, I keep accidentally closing cards when I'm setting up an integration. Setting up most integrations requires bouncing between multiple tabs (e.g., to retrieve a GitHub PAT), and when you click back into Chariot, it's easy to accidentally click outside the card. This closes the tab and erases whatever you had already pasted into the card, which can be annoying.
Preferred Solution Chariot would only close the integration card if the user clicks a button. Clicking outside the card would just do nothing.
Alternatives Considered Maybe I'm alone in my opinion, in which case an alternative would be to leave the UI as is.