praetorian-inc / chariot-ui

Chariot Offensive Security Platform
https://preview.chariot.praetorian.com
MIT License
15 stars 6 forks source link

Risk definition documents are getting classified as "Manually Uploaded Files" #177

Open treburn opened 4 days ago

treburn commented 4 days ago

Bug Description Risk definition documents are getting classified as "Manually Uploaded Files"

Screenshot 2024-06-26 at 2 33 21 PM
peter-kwan commented 3 days ago

I checked with @storbeck. This is in the backend.

noah-tutt-praetorian commented 3 days ago

Were these ML generated or uploaded by the end user?

If the latter, then this makes sense. We don't allow the user to specify class when uploading files. I'm not sure if we should or if there's another way to handle this.

privateducky commented 3 days ago

closing duplicate around this: https://github.com/praetorian-inc/chariot-ui/issues/164

privateducky commented 3 days ago

Were these ML generated or uploaded by the end user?

If the latter, then this makes sense. We don't allow the user to specify class when uploading files. I'm not sure if we should or if there's another way to handle this.

Most likely; I think we should adjust though and ensure manually uploaded files can set a class upon upload.

noah-tutt-praetorian commented 3 days ago

backend: https://github.com/praetorian-inc/chaos/pull/914

CLI: https://github.com/praetorian-inc/praetorian-cli/pull/51

privateducky commented 3 days ago

backend: praetorian-inc/chaos#914

CLI: praetorian-inc/praetorian-cli#51

Backend merged.

peter-kwan commented 2 days ago

Fix in CLI is published in 1.1.2.

@Ash-Cat and @noah-tutt-praetorian -- keep us posted on the patching of the existing definitions in the system. Once patched, this issue is considered done.