praetorian-inc / chariot-ui

Chariot Offensive Security Platform
https://preview.chariot.praetorian.com
MIT License
15 stars 6 forks source link

Auto-Open Opening Rejected Risks #184

Open Ameston opened 3 days ago

Ameston commented 3 days ago

Bug Description Auto-Open is actioning findings that have never been validated and opened by an operator in the past.

Steps to Reproduce

  1. Reject a risk
  2. Wait for it to be detected again

Expected Behavior Any risks that haven't been manually verified and OPENED by an operator should not automatically open.

Screenshots

image
noah-tutt-praetorian commented 3 days ago

Interesting, it should only be opening findings that are in the closed (no substate) state.

privateducky commented 3 days ago

now this IS a feature we're just starting to work on (it's not even written though, never mind deployed lol).

noah-tutt-praetorian commented 3 days ago

@Ameston and I have determined that this is likely just old data, given that the code on main does handle this case correctly. The risk here changed from rejected -> resolved at some point without a history entry