praetorian-inc / chariot-ui

Chariot Offensive Security Platform
https://preview.chariot.praetorian.com
MIT License
15 stars 6 forks source link

Pagination broken in UI #44

Closed peter-kwan closed 3 weeks ago

peter-kwan commented 3 weeks ago

Bug Description I have set my personal stack to return only 5 results for each page. The UI does not let me scroll pass 5 when there are 429 results. The count is also not showing 429.

Steps to Reproduce

Expected Behavior I expect the card to say 429 and that I can page to the next 5 results over and over again as I scroll down the table.

Screenshots Screenshot 2024-06-13 at 5 08 52 PM

storbeck commented 3 weeks ago

This is not a bug.

Pagination is initiated through a scrolling action as during typical workflows you will get back many thousands. This is an intentional choice, if you force it to return early and in a small enough batch that you can't scroll you are just forcing it into a circumstance that it should never reach under normal behavior.

peter-kwan commented 3 weeks ago

I now understand that the page size of 5 was too small. I tested it with a page size of 30 and the UI pages as expected.

There are other nuances on the numbers on the filter cards. However, those are not important at this point to warrant putting time into it.