search

praetorian-inc / chariot-ui

Chariot Offensive Security Platform
https://preview.chariot.praetorian.com
MIT License
15 stars 6 forks source link

Set value field for integrations #64

Closed noah-tutt-praetorian closed 2 weeks ago

noah-tutt-praetorian commented 2 weeks ago

Summary

Ensures that value is set for relevant integrations. This prevents the issue noted in https://github.com/praetorian-inc/chaos/pull/850. Also ensures that results from these integration are searchable.

Type

Bug Fix

storbeck commented 2 weeks ago

This value is already provided by the username field. Why does it need defined twice?

noah-tutt-praetorian commented 2 weeks ago

Those two values don't have the same meaning - one is a type, and the other is a specifier. Currently, we only support one of these types of integration (on the frontend, the backend will support any number), but the specifier still needs to be populated with a value.

I'm open to any other naming scheme, there just needs to be some value there, and preferably one that makes sense for search.

Maybe we let the user specify?

noah-tutt-praetorian commented 2 weeks ago

@storbeck more elegant solution here: https://github.com/praetorian-inc/chariot-ui/pull/69