search

praetorian-inc / chariot-ui

Chariot Offensive Security Platform
https://preview.chariot.praetorian.com
MIT License
15 stars 6 forks source link

Add integration identifiers (name, URL, ID, etc) as the account value instead of the integration field #69

Closed noah-tutt-praetorian closed 2 weeks ago

noah-tutt-praetorian commented 2 weeks ago

Summary

Ensures that all integrations that create seeds set the value field. Requires backend changes, but is a better solution than https://github.com/praetorian-inc/chariot-ui/pull/64 in aggregate. Fixes https://github.com/praetorian-inc/chariot-ui/issues/68.

Type

Bug Fix

storbeck commented 2 weeks ago

Looks like this got auto-closed based on some magic words that @noah-tutt-praetorian said in the cli repo. Re-opening

noah-tutt-praetorian commented 2 weeks ago

Whoops. This is ready for review @storbeck, CLI and backend are in

peter-kwan commented 2 weeks ago

@storbeck and @noah-tutt-praetorian -- that is right!

This is the list of words that will force an auto-close on an issue when the PR is merged to main:

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword