praetorian-inc / chariot-ui

Chariot Offensive Security Platform
https://chariot.praetorian.com
MIT License
21 stars 6 forks source link

comments on risks not saving #728

Closed praetorian-matt-schneider closed 12 hours ago

praetorian-matt-schneider commented 2 days ago

https://praetorianlabs.slack.com/archives/C06RDPMGZJS/p1726522519013329

Dan-Crawford commented 2 days ago

This issue relates to comments on the Risk page not persisting on that risk after hitting save.

Comments are added to the comment section immediately below the drop down that changes the status from "Open" to "Closed".

Comments should persist in the modal after hitting save.

peter-kwan commented 2 days ago

I reproduced a symptom that wasn't exactly the same as @praetorian-matt-schneider's.

I was able to get the comment and status change persisted.

However, when I was just adding a comment, it did not save.

From the browser's network tab, it looks to me that the frontend is sending the right information to backend in a PUT call. It looks to me a backend bug.

noah-tutt-praetorian commented 1 day ago

https://github.com/praetorian-inc/chariot-client/pull/71/files

peter-kwan commented 1 day ago

Fix above from @noah-tutt-praetorian is merged. Pending deployment of it.

praetorian-harry commented 1 day ago

@praetorian-matt-schneider we have deployed a fix for this issue. Please close the issue if you are satisfied with the fix. Thank you!

peter-kwan commented 1 day ago

Actually. It wasn't yet deployed, due to not pulling the latest.

peter-kwan commented 1 day ago

@praetorian-matt-schneider -- it is actually fixed.

Dan-Crawford commented 22 hours ago

Confirmed comments on risks persist when added in "Requires Remediation" state and "Remediated" state.

praetorian-matt-schneider commented 12 hours ago

confirmed - thank you!