search

praetorian-inc / chariot-ui

Chariot Offensive Security Platform
https://preview.chariot.praetorian.com
MIT License
15 stars 6 forks source link

github secrets scanning results POE links are broken #73

Closed praetorian-matt-schneider closed 2 weeks ago

praetorian-matt-schneider commented 2 weeks ago

Bug Description links generated to secrets identified through github secrets scanning appear to be of the form https://github.com/<org-or-user>/<repo>/<file_path>. this produces broken links that will 404.

Steps to Reproduce

  1. identify a risk sourced from github secrets scanning.
  2. navigate to proof-of-exploit
  3. click on the link and observe that it is not found.
  4. scan the repo locally using NP and identify the secret, noting the commit hash
  5. add /blob/<commit> between the repo and file path to the link provided by chariot
  6. observe the link working

Expected Behavior i think the correct format for the links should be https://github.com/<org-or-user>/<repo>/blob/<commit_id>/<file_path>

Screenshots image image

Additional Information note that the commit id is important - this will allow us to reach files that may have been removed from the current version but that are still accessible in commit history and may contain secrets.

storbeck commented 2 weeks ago

Fixed, this was a bug.

That screen is intended for webcrawler produced links to form inputs. It shouldn't have been shown for nosey parker produced risks.

praetorian-matt-schneider commented 2 weeks ago

confirmed - thanks!