search

praetorian-inc / chariot-ui

Chariot Offensive Security Platform
https://chariot.praetorian.com
MIT License
21 stars 5 forks source link

Outdated risk links sent in slack #765

Open flaviusscorpus opened 1 hour ago

flaviusscorpus commented 1 hour ago

Bug Description

Outdated risk links sent in slack:

Current / Outdated: https://preview.chariot.praetorian.com/risks?riskKey=#risk#factiorussata.com#generic-env

Working: https://chariot.praetorian.com/app/risks?drawerCompositeKey=%23risk%23factiorussata.com%23generic-env

Steps to Reproduce

  1. Get a Slack alert about a new risk.
  2. Click the link in the alert (https://preview.chariot.praetorian.com/risks?riskKey=#risk#factiorussata.com#generic-env)
  3. I am looking at the attack surface page, not the risk.

Expected Behavior I would expect to view the risk when I click the link.

Screenshots

_3__-_Inbox_-_Zoho_Mail__flaviusscorpus_factiorussata_com_

System Information

Additional Information Any other details.

noah-tutt-praetorian commented 1 hour ago

These are old (september 4th). New alerts will have the correct link: https://github.com/praetorian-inc/chariot-client/blob/31ed271943aa4fcf31d38cb8500f71d236af6485/pkg/sdk/model/risk.go#L97-L99

flaviusscorpus commented 1 hour ago

That code still says risks?riskKey=%s", r.Key) but it should be app/risks?drawerCompositeKey=%s", r.Key) i think.

noah-tutt-praetorian commented 1 hour ago

Ah, good call

noah-tutt-praetorian commented 1 hour ago

https://github.com/praetorian-inc/chariot-client/pull/96/files