praetorian-inc / chariot-ui

Chariot Offensive Security Platform
https://preview.chariot.praetorian.com
MIT License
15 stars 6 forks source link

Seeds page - CIDR ranges that are /21 or larger are showing duplicate entries in the modal #99

Closed treburn closed 1 week ago

treburn commented 1 week ago

Bug Description On the seeds page, CIDR ranges that are /21 or larger are showing duplicate entries in the modal

Steps to Reproduce

  1. Go to the seeds page
  2. Open a CIDR range that is /21 or larger
  3. View duplicate entries

Screenshots Video in internal channel

noah-tutt-praetorian commented 1 week ago

@storbeck what data are we trying to show there? It looks like this is derived from attributes somehow.

storbeck commented 1 week ago

I saw this on a /24 - these are seed attributes, looks like we should be displaying dns instead of name.

Screenshot 2024-06-19 at 4 11 52 PM
storbeck commented 1 week ago

Thinking about it a bit more, is that even a useful thing to show? I think it is not.

noah-tutt-praetorian commented 1 week ago

Yeah, these records are used to derive the assets originated by a seed. For now we can probably remove the generic attributes display from the seed window.

storbeck commented 1 week ago

That is only for seed class, but we could also get other attributes such as expiration and purchased unless those were removed?

noah-tutt-praetorian commented 1 week ago

ah, right - no they weren't. just ignoring seed class might be a good idea then

storbeck commented 1 week ago

Cool, thanks for confirming @noah-tutt-praetorian. I've pushed the above change to filter out seed attributes. If no other attributes are found, the window will not appear.

Screenshot 2024-06-19 at 4 41 01 PM
storbeck commented 1 week ago

@noah-tutt-praetorian you removed the done label when adding the bug label. Was this an accident or is there more work to be done?

noah-tutt-praetorian commented 1 week ago

Not intentional, my bad