Emit JSON output only once; improve error reporting

praetorian-inc / gokart

A static analysis tool for securing Go code

Apache License 2.0

2.18k stars 110 forks source link

Closed bradlarsen closed 2 years ago

bradlarsen commented 2 years ago

Previously, due to copy-and-paste, GoKart's JSON output would be emitted twice. This pull request fixes that.

Additionally, this pull request improves the error reporting when an unknown command is given to GoKart.

bradlarsen commented 2 years ago

Converting this back to a draft, since I've found a couple more JSON-related output issues that I want to fix

bradlarsen commented 2 years ago

This fixes #52, #56, and #57.

praetorian-thendrickson commented 2 years ago

Looks good to me, I tested locally and confirmed the fixes for the three identified bugs. Thanks!

bradlarsen commented 2 years ago

Thanks for the review @praetorian-thendrickson and @isp1r0! :)