search

praetorian-inc / gokart

A static analysis tool for securing Go code
Apache License 2.0
2.18k stars 110 forks source link

fix: Update to GO 1.18 so scan works on new projects #75

Closed adadkins closed 2 years ago

adadkins commented 2 years ago

If you run gokart scan on go 1.18 projects, you get an error:

internal error: package "time" without types was imported from "github.com/Omaze/cl-sweeps-api/internal/common"

We need to have a 1.18 build for gokart for it to work with new go projects

ynsta commented 2 years ago

Would also need this fix.

adadkins commented 2 years ago

@isp1r0 @praetorian-harry Hey sorry to ping, just curious if we can merge this so gokart works with new go projects

sc-atompower commented 2 years ago

@ynsta @adadkins the go team recently announced https://go.dev/blog/vuln

adadkins commented 2 years ago

@sc-atompower thanks for that, i did not see that announcement. I'm gong to close this PR and switch to using that. Thanks

nekochanell commented 2 years ago

@ynsta @adadkins the go team recently announced https://go.dev/blog/vuln

It's not even the same thing. GoKart is a static code analyser. GoVulnCheck is for dependency vulnerability management.

This issue should be reopened.

adadkins commented 2 years ago

Reopening

praetorian-thendrickson commented 2 years ago

Hey @adadkins thank you for your help with this PR. I updated it slightly, so the current main branch https://github.com/praetorian-inc/gokart/pull/80 should now work.