search

praetorian-inc / noseyparker

Nosey Parker is a command-line program that finds secrets and sensitive information in textual data and Git history.
Apache License 2.0
1.66k stars 79 forks source link

Implement `rustfmt` CI checks #134

Closed seqre closed 7 months ago

seqre commented 7 months ago

The code got formatted according to the existing .rustfmt.toml. Additionally, I've added a CI check for code formatting.

github-advanced-security[bot] commented 7 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

bradlarsen commented 7 months ago

@seqre in the future, if you don't mind, please check allow edits by maintainers on your Nosey Parker PRs — sometimes this can speed up the review/merge process instead of me asking for a small change.

bradlarsen commented 7 months ago

I made one followup change to opt out of rustfmt formatting for one function, which ends up much less readable after auto-formatting: 06cc1fa2b33f10dcb22e652f9817fc5d44247b94.

I'm curious to see what pre-commit integration for this project would look like, specifically for the rustfmt check available here.

bradlarsen commented 7 months ago

See #135 for pre-commit support.