Closed tobiasgyoerfi closed 4 months ago
@tobiasgyoerfi thanks, this looks good!
P.S. I retrained the failing tests with cargo insta test --review
.
I also updated the CHANGELOG. Thank you for allowing maintainers to edit this pull request!
Thanks for the contribution 🍻
Okay, I also used GitHub Code search to investigate the signal to noise of this new rule.
What you had originally written turns up many false positives. For example, searching for that pattern gives this result:
dapiDataGetTopLongShortPositionRatio (params?: {}): Promise<implicitReturnType>;
I looked at some examples that appear to be real and noticed a couple things:
-NUMBER
suffix after the 32 payload charactersMaking those changes produces far fewer false positives.
Thank you again!
Adding a rule for Databricks Personal Access Token detection and enabling it in the default ruleset.