search

prafulljha / maven-replacer-plugin

Automatically exported from code.google.com/p/maven-replacer-plugin
MIT License
0 stars 0 forks source link

The basepath of the FileSet should be ${basedir} and/or configurable #31

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Right now the includes/excludes directives search in the directory of new
File('.') which will point to the current directory where mvn is executed.

So when you do multimodule builds the replacer of one single module
replaces files in all other modules too.

Suggestion: Add a config value directory to the mojo and default it to
${basedir}

Original issue reported on code.google.com by lcorneliussen@googlemail.com on 31 Mar 2010 at 8:55

GoogleCodeExporter commented 9 years ago 
Code to be found in Line 19 in
http://code.google.com/p/maven-replacer-plugin/source/browse/trunk/src/main/java
/com/google/code/maven_replacer_plugin/include/FileSelector.java

Original comment by lcorneliussen@googlemail.com on 31 Mar 2010 at 8:57

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
I will certainly add this as an enhancement for the next release.

In the meantime, can you work around this by specifying 
${basedir}/file/to/include,
making it an absolute path in each include/exclude?

Original comment by baker.st...@gmail.com on 1 Apr 2010 at 2:34

GoogleCodeExporter commented 9 years ago 
Hi,

that somehow doesn't work on Windows, because of backslashes in basedir.

- Lars

Original comment by lcorneliussen@googlemail.com on 2 Apr 2010 at 5:34

GoogleCodeExporter commented 9 years ago 
Hi Lars,

I have made the changes for optionally specifying a basedir in the 
configuration.
{{{<configuration>
    <basedir>(some base dir string)</basedir>
    ...
}}}

It would be fantastic if you could test this out for yourself.
So far this change only exists in the trunk for the 1.3.1 release. Check out 
the 
InstallationGuide on how to install the plugin using the source code.

Original comment by baker.st...@gmail.com on 3 Apr 2010 at 12:37

GoogleCodeExporter commented 9 years ago 
Sorry, please ignore the {{{ and }}}, I was expecting google code to wrap the 
insides 
in a css code fragment.

Original comment by baker.st...@gmail.com on 3 Apr 2010 at 12:38

GoogleCodeExporter commented 9 years ago 
Hi,

thank you. It works for me.
When do you plan on releasing 1.3.1?

- Lars

Original comment by lcorneliussen@googlemail.com on 12 Apr 2010 at 8:45

GoogleCodeExporter commented 9 years ago 
I was mostly just waiting for you to confirm this was working before going 
ahead with a 
release.

I will be releasing soon, just need a bit of free time this week.

Original comment by baker.st...@gmail.com on 13 Apr 2010 at 7:31

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
1.3.1 has been released into the google hosted repo, and I am waiting for it to 
be 
added to the maven central repo, 
see: http://jira.codehaus.org/browse/MAVENUPLOAD-2767

In the meantime, you can point your maven settings at the google repo by 
following 
the instructions in the InstallationGuide.

I will update the project documentation soon.
Thanks,
Steven

Original comment by baker.st...@gmail.com on 17 Apr 2010 at 12:10

GoogleCodeExporter commented 9 years ago 
1.3.1 is now within the central maven repository. You can now remove any 
references to 
this projects release repository.

Original comment by baker.st...@gmail.com on 7 May 2010 at 2:27

GoogleCodeExporter commented 9 years ago 
Just issue clean up.

Original comment by baker.st...@gmail.com on 17 Sep 2012 at 12:46