search

pragatir / shellinabox

Automatically exported from code.google.com/p/shellinabox
Other
0 stars 0 forks source link

Question trying to implement switch to turn on/off cursor blinking #82

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I would like to implement an easy command line switch that enables/disables 
cursor blinkage. I wouldn't even mind doing it myself, I'm just not sure where 
the JavaScript is that's making it blink. I've tried editing the 
shell_in_a_box.js(pp) and disabling the blinkage, but after recompiling (make 
distclean, etc) and running nothing seemed to change.

Love the project and thanks in advance,

Chrelad

Original issue reported on code.google.com by chre...@gmail.com on 6 Aug 2010 at 4:42

GoogleCodeExporter commented 9 years ago 
You should only ever have to edit the shellinabox/vt100.jspp file. The *.js 
file is generated from the *.jspp file when you invoke "make".

I would suggest you make this an option that can be enabled/disabled from the 
context menu. That way, user's can decide for themselves whether they prefer a 
blinking cursor. And the settings will be persisted in a browser cookie.

You can search for how the code uses other options (e.g. autoprint) to see how 
this is done.

When introducing new options, you should also update the cookie signature.

In fact, all of this is easy enough, I think I'll make a quick change and you 
can let me know if it does what you want. Give me a few minutes.

Original comment by zod...@gmail.com on 6 Aug 2010 at 5:30

GoogleCodeExporter commented 9 years ago 
Subversion seems to be read-only at this time. I'll eventually commit the 
change to the official tree, but for the time being please refer to the 
attached patch file.

Original comment by zod...@gmail.com on 6 Aug 2010 at 5:56

Attachments:

GoogleCodeExporter commented 9 years ago 
Beautiful, and quick too :D That's exactly what I was looking for. Also, it's 
nice to look at the patch and see what it takes to add a feature like that. 
I'll keep that patch handy as a reference in case I want to add a feature in 
the future.

Thanks for the quick work and great project,

Chrelad

Original comment by chre...@gmail.com on 6 Aug 2010 at 9:42