pragdave / e4p2-hangman

24 stars 14 forks source link

Type referencing a function instead of the type #2

Closed Darova93 closed 2 years ago

Darova93 commented 2 years ago

Shouldn't this line be changed from this

https://github.com/pragdave/e4p2-hangman/blob/64e8bd7c6658db2a7c36c45ef72431d9c2989d39/text_client/lib/impl/player.ex#L4

to this:

@typep tally :: Hangman.Type.tally() 

Otherwise it seems to reference the Hangman.tally function

pragdave commented 2 years ago

You are absolutely right. I've pushed changes to the affected branches.

Good spotting.

Dave

On Thu, Mar 24, 2022 at 3:10 AM David Rodriguez Vazquez < @.***> wrote:

Shouldn't this line be changed from this

https://github.com/pragdave/e4p2-hangman/blob/64e8bd7c6658db2a7c36c45ef72431d9c2989d39/text_client/lib/impl/player.ex#L4

to this:

@typep tally :: Hangman.Type.tally()

Otherwise it seems to reference the Hangman.tally function

— Reply to this email directly, view it on GitHub https://github.com/pragdave/e4p2-hangman/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACTGGPW3GJ76OZXEWBYE3VBQPQLANCNFSM5RQKQTGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>