pragdave / earmark

Markdown parser for Elixir
Other
860 stars 135 forks source link

Fix unused variable warnings #453

Closed jcrevits closed 1 year ago

jcrevits commented 1 year ago

Hello! I noticed a few warnings when upgrading to the latest version 👇

I'll leave it up to you if you would rather keep the pattern matching but prefix the variables with _. I went for the other option.

Thank you for maintaining this lib! :)

Compiling 15 files (.ex)
warning: variable "fno" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/earmark/options.ex:201: Earmark.Options._check_options!/1

warning: variable "line" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/earmark/options.ex:205: Earmark.Options._check_options!/1

warning: variable "fno" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/earmark/options.ex:209: Earmark.Options._check_options!/1

warning: variable "line" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/earmark/options.ex:209: Earmark.Options._check_options!/1

Generated earmark app
RobertDober commented 1 year ago

Thank you for doing my job ;) Shoudda have caught this one.

I'll leave it up to you if you would rather keep the pattern matching but prefix the variables with _. I went for the other option.

Perfectly fine what you did!

RobertDober commented 1 year ago

Je suppose que nous sommes Français/francophone, tous les deux (bien je le sais pour moi ;)) donc Merci Encore

jcrevits commented 1 year ago

Effectivement ! Un bon nombre de français/francophones maintiennent/trainent dans le monde d'Elixir 😛 De rien et bon courage !