pragdave / earmark

Markdown parser for Elixir
Other
859 stars 135 forks source link

Avoid trailing slash on void elements. #460

Closed jaimeiniesta closed 1 year ago

jaimeiniesta commented 1 year ago

Although void elements are allowed to have a trailing slash, the W3C Validator will issue a warning in that case, as it's now recommended to avoid trailing slash on void elements:

Captura de pantalla 2023-04-25 a las 12 49 03

More information here:

https://github.com/validator/validator/wiki/Markup-%C2%BB-Void-elements

RobertDober commented 1 year ago

¡Muchìsimas gracias por ese PR!

... I'll prbably just ridicule myself in castellano and maybe others need to read this too, therefore...

Firstlly thanx this surely has great value and will be released soon Secondly I am happy with many of the format changes you made and can tolerate some although I dislike them personally And last but not least: I really dislike some changes of text in the tests so would you be ok to revert some of them, I will make the remarks in a CR as soon as I have time

jaimeiniesta commented 1 year ago

Hola @RobertDober, muchísimas gracias a tí :)

Thanks for reviewing this, of course, feel free to revert some of the changes if needed.

Format changes were not intended, and they were applied automatically by my editor. But as those come from the official mix format I thought it would be OK to leave them.

Let me know if you want me to change anything but yes, feel free to revert changes or improve the PR.

RobertDober commented 1 year ago

yes we will keep these of course

Sed nostra omnis vis in animo et corpore sita est

C. Sallustii Crispi

On Tue, Apr 25, 2023 at 1:15 PM Jaime Iniesta @.***> wrote:

Hola @RobertDober https://github.com/RobertDober, muchísimas gracias a tí :)

Thanks for reviewing this, of course, feel free to revert some of the changes if needed.

Format changes were not intended, and they were applied automatically by my editor. But as those come from the official mix format I thought it would be OK to leave them.

Let me know if you want me to change anything but yes, feel free to revert changes or improve the PR.

— Reply to this email directly, view it on GitHub https://github.com/pragdave/earmark/pull/460#issuecomment-1521614489, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASK57PJEZGVS7J7UCUJHDXC6W6HANCNFSM6AAAAAAXK2JLJM . You are receiving this because you were mentioned.Message ID: @.***>

RobertDober commented 1 year ago

Hola again

unfortunately the CI is making problems, so I will just merge and change some things back in the tests, if the tests are ok I will release if I have any problems I'll come back to you.

Supongo que los tests funccionen en(?) tu maquina local?

jaimeiniesta commented 1 year ago

Hey yes, the tests pass in my machine :D

jaimeiniesta commented 1 year ago

CI is waiting for a runner 🏃‍♀️

RobertDober commented 1 year ago

Excellente

I had authorized the runner \o/ what happened

aùn gracias y voy sicuramente hacer un release este weekend prolongado(sp?)

RobertDober commented 1 year ago

Ah finally I understand your changes in the tests too! 👍 Getting old I guess 😢

RobertDober commented 1 year ago

Published

jaimeiniesta commented 1 year ago

Great! Thanks! 🥸