Closed tercenya closed 11 months ago
Thank you for reporting this
I'm sorry I don't have a quick reproduction case, as I'm calling Earmark as a LiveView component and haven't isolated this issue out yet. Given the size/scope of the v1.4.41 merge that still not on master, figured I would give a heads up if this makes sense to someone in the know.
You reported this very nicely, I can see the stupid misstake I made, just that I am on leave and cannot really investigate why the tests did not check this. Hopefully fixed with the just released 1.4.42
Not fixed in 1.4.42 on Elixir 1.15.5 (compiled with Erlang/OTP 26) I'm afraid
~Sorry about that, will need some time to check this out, time I do not have right now. Thank you for your patience.~
How stupid can one get (please do not answer) @tercenya very nicely identified the problem by referring to #80, now I just checked #80 so this should do the trick
:blush: ๐ ๐
Thank you. It may be worth yanking 1.4.41/42 from Hex?
Thank you. It may be worth yanking 1.4.41/42 from Hex?
Completely agree, however can this still be done?
Yes, it's possible to retire a specific version
Ty for your reply, I have looked at the hex.retire
and it is my understanding that it retires the whole package not a version (although I wonder why we need a version in the command, then)
So I get cold feet, honestly.
But thank you for your time.
I'll be a little bit more precise, I quote the doc
mix hex.retire
Retires a package version.
Great so far
Mark a package as retired when you no longer recommend its usage.
I beg you pardon ๐จ
I will test with a dummy package when I have some time; probably not soon, sorry
Yeah, I found it confusing too.
Here's an example though:
Timex 3.6.2 https://hex.pm/packages/timex/versions
During one of the recent Thinking Elixir podcast it was mentioned that it can be done by asking Hex maintainers, but they have a policy limiting it to 48h after release if I'm not mistaken.
During one of the recent Thinking Elixir podcast it was mentioned that it can be done by asking Hex maintainers, but they have a policy limiting it to 48h after release if I'm not mistaken.
Is that not for overwriting the same version, which also can be done during 1h IIRC with the CLI.
Maybe this is one of the areas where documentation could be improved.
Here's an example though:
Timex 3.6.2 https://hex.pm/packages/timex/versions
Well are we sure there was ever a version 3.7.10 ? I have occasonally skipped patch version numbers.
Ty all for your participation, but I'll just test with a dummy package. ;)
Action : Retire versions 1.4.4[12] if savely possible.
DONE
Ty all for your help
Thank you ๐๐ป
With v1.4.41, I get
I'm sorry I don't have a quick reproduction case, as I'm calling Earmark as a LiveView component and haven't isolated this issue out yet. Given the size/scope of the v1.4.41 merge that still not on master, figured I would give a heads up if this makes sense to someone in the know.
Other things I tried:
Version info: