search

pragdave / earmark

Markdown parser for Elixir
Other
859 stars 135 forks source link

Duplicated modules using earmark and earmark_parser #473

Closed EasterPeanut closed 11 months ago

EasterPeanut commented 11 months ago

I get this error in my release when using both earmark 1.4.45 and earmark_parser 1.4.36:

** (Mix) Duplicated modules: 
        string_lexer specified in earmark and earmark_parser
    link_text_parser specified in earmark and earmark_parser
    link_text_lexer specified in earmark and earmark_parser
RobertDober commented 11 months ago

Thank you EasterPeanut, you put the finger where it hurts, actually the fix should not be too difficult, I need to change the names of the lexers in Earmark however there are two problems here

  1. I am not planning to maintain Earmark any longer, but I might be able to squeeze a "fix" (see below) in this WE (but no promises)
  2. @josevalim, should this even happen? Looks like a bug to me that the leex and yeec files leak from the package? @EasterPeanut could you please provide us with the complete setup of your application?
RobertDober commented 11 months ago

Note to self: Pseudo namespace lexer and yecc in Earmark and EarmarkParser

josevalim commented 11 months ago

@RobertDober I can submit PRs for both if you want. :)

lifeofdan commented 11 months ago

Isn't this fixed with the merge of https://github.com/pragdave/earmark/pull/474 ? If it is, this could be marked as closed.

RobertDober commented 11 months ago

@lifeofdan Thank you for the reminder