Open RobertDober opened 3 months ago
Thanks, this helps a lot! Do you have a vision on how changes to parsers should or should not be ported between them? A good example is https://github.com/RobertDober/earmark_parser/pull/142 which would be a great fit for Earmark package I think.
Thanks, this helps a lot! Do you have a vision on how changes to parsers should or should not be ported between them? A good example is https://github.com/RobertDober/earmark_parser/pull/142 which would be a great fit for Earmark package I think.
Concerning the example, I agree with you, ... #502 I guess it might be a good idea to cross reference or link the issues between the two repos. #501 is a good example where the same has to be done in both projects. There are two things that surprise me
I propose to put something like the following quite on top of the README, input from @martosaur @https://github.com/dominicletz and of course @amit-chaudhari1 is most welcome
EarmarkParser
vs.Earmark
Historically
EarmarkParser
was extracted out fromEarmark
becauseex_doc
did only use theAST
when it became available during the evolution ofEarmark
.For some time
Earmark
usedEarmarkParser
before generating the HTML.Now however, especially as I have found a new maintainer in the person of @amit-chaudhari1 and both projects are free to implement the kind of markdown and featureset best suited for them, the two projects are independent.
We are aware that this might be confusing for some time but here are some basic rules that should help.
What to install
If you use
ex_doc
you useEarmarkParser
as a dependency, now and only now you can work withEarmark
as a dependency without risking a conflict.If you want to transform Markdown into an AST you have two options, depending on the feature set you want to use. In case you use
Earmark
all is clear. If you needEarmarkParser
you might have conflicts withex_doc
However there is a simple fix for this provided by José Valim himself, here is how to create your docs withoutex_doc
as a dependency https://github.com/RobertDober/earmark_parser/blob/5228fce46509ff1bc0c727eeeef8b2d20774ecc1/mix.exs#L33 and https://github.com/RobertDober/earmark_parser/blob/5228fce46509ff1bc0c727eeeef8b2d20774ecc1/mix.exs#L65-L83If you want HTML
Earmark
is your only option.How to report bugs
A very simple rule
If you have Bugs which are raised in ex_doc report to ex_doc or EarmarkParser, communication between us is great 👼 If you have
EarmarkParser
in your deps report toEarmarkParser
If you haveEarmark
in your deps report toEarmark
But I have both
Then report according to your feeling, nobody will be mad with you, we will route the issue between the two projects w/o any hussle. Again great communication :wink: