Support all audio files recognized by GNOME's GIO

[OlekMazur]

1. Remove built-in white lists of supported MIME types (apart from playlists, which need special handling)
2. Don't discard files without tags recognized by taglib

This should cover all future issues similar to #58.

[matiasdelellis]

Hi @wymiatacz It is a welcome change.. :smiley:

It is a change that I've been thinking a while.. But the problem to solve is that every time that save a tag change pragha try to save tags using taglib regardless if support it or if it is a CD or an MTP device where not work.. Let me see as a complement to solve this too .... :wink:

Thanks for all, Regards,

[OlekMazur]

Hi @matiasdelellis Let me know what do you think about new version of the change. Regards

[matiasdelellis]

Hi @wymiatacz Sorry for the delay in answering, and the slow progress in the development.. 😞 You're right.. I have few excuses to do this .. Even more taking in account the advances in Ampache or mtp.. I have to differentiate the files that can edit taglib, and the read only services... 😉

[OlekMazur]

I just uploaded a new version of the change a few days ago and asked you for a comment. This time the change proposal is much less, let's say, invasive than the original one. If you tell me what's wrong with it, I can try to improve it further.

With my change, the "Edit track information" option is still available and shows the tag edition dialog even if the track is unsupported by taglib (therefore clicking OK has no effect). The error in saving tags is silently ignored. Is this the only problem, or do you see others? Do you have a proposal how it should behave? Graying out this option for files unsupported by taglib?

[matiasdelellis]

Hi @wymiatacz Excuse me again, between being busy, I lost my computer with a lot of information, and now I'm coming back.. Your proposal in principle is correct, but for the future release of pragha probably falls short.. 😉

I just wanted to plan a more comprehensive proposal:

• That the database and the PraghaMusicobjet have the information if it can be edited..
• If one or more selected songs can not be edited, show some warning in the dialog. (If you edit these files when update/analyzing the collection, they may be lost), or perhaps not allow editing..
• If can edit, that each PraghaProvider (MTP, can be editable, Ampache theoretically the administardador could edit, but the users can not. CDROM not..) is responsible for modifying its files.
• ..

But in principle, adding an option to "Allow partially supported files" as a warning, would be enough to accept your proposal.