search

pragha-music-player / pragha

Pragha is a Lightweight Music Player for GNU/Linux.
GNU General Public License v3.0
173 stars 35 forks source link

Easy to miss dependency on exo #128

Closed mgorny closed 6 years ago

mgorny commented 6 years ago

Hi,

It seems that exo-csource is kinda-unconditionally used in Makefiles, e.g.:

pragha-window-ui.h: pragha-window.ui Makefile
    $(AM_V_GEN) exo-csource --strip-comments --strip-content --static --name=pragha_window_ui $< > $@

Note that due to dep on Makefile, this will be always regenerated. However, configure doesn't check for the presence of exo, and I can't grep it anywhere in package sources. Therefore, it is easy to miss the build-time dependency.

matiasdelellis commented 6 years ago

@mgorny Fixed.. Thank you so much.. 😉