pragha-music-player / pragha

Pragha is a Lightweight Music Player for GNU/Linux.
GNU General Public License v3.0
173 stars 35 forks source link

Hardcoded plugin path in 1.3.91 release tarball #135

Closed casta closed 6 years ago

casta commented 6 years ago

Hi,

Looking why plugins where missing, I found this. It seems that the release 1.3.91 tarball contains hardcoded dev path. Look at this, diffing 1.3.91 tarball versus git:

# diff -u pragha-1.3.91/src/pragha-plugins-engine.c ~casta/repository/pragha/src/pragha-plugins-engine.c 
--- pragha-1.3.91/src/pragha-plugins-engine.c   2018-01-18 16:05:51.000000000 +0100
+++ /home/casta/repository/pragha/src/pragha-plugins-engine.c   2018-04-09 13:31:51.348093826 +0200
@@ -180,8 +180,7 @@

        engine->object = g_object_ref(object);

-//     peas_engine_add_search_path (engine->peas_engine, LIBPLUGINDIR, USRPLUGINDIR);
-       peas_engine_add_search_path (engine->peas_engine, "/home/matias/Desarrollo/pragha/plugins/", "/home/matias/Desarrollo/pragha/plugins/");
+       peas_engine_add_search_path (engine->peas_engine, LIBPLUGINDIR, USRPLUGINDIR);

        engine->peas_exten_set = peas_extension_set_new (engine->peas_engine,
                                                         PEAS_TYPE_ACTIVATABLE,

I think this deserves a new release ;)

Thanks !

matiasdelellis commented 6 years ago

D'oh!!

I use it to test changes in the plugin without installing continuously.. :disappointed: Thanks you @casta :wink:

matiasdelellis commented 6 years ago

Ohh ... I'm seeing that the tarball is with the pach. but never commit these change by luck. Now I pack it again..

casta commented 6 years ago

Thanks ;)

matiasdelellis commented 6 years ago

Please.. Test lasr tarball... And tanks again... :smile:

casta commented 6 years ago

Confirmed fixed, thanks !