Fix for the issue 129

[np2048]

>Corrupt files should not block advancing in play list #129

Fist of all the player should not stop the playback when it suddenly "finds" a corrupted file in the playlist. This is done by a quick fix.

But it wouldn't be a good solution to just get rid of the error message. So I decided to keep the error message dialog but show it only in certain occasions: when user explicitly wants to play a file that is corrupted.

In order to achieve it I had to add a variable to the _PraghaPlaylist struct. ` / Useful flags /

gboolean changing; gboolean dragging; gboolean implicit_track; gint no_tracks; GError *track_error; ` The variable implicit_track indicates that a music object is to be played from somewhere in the middle of the playlist, after calling of the functions go_prev_track and go_next_track.

That variable is checked after updating the playlist and setting the mark in the file line indicating that the file is corrupted (pragha-window.c). `void gui_backend_error_update_current_playlist_cb (PraghaBackend backend, const GError error, PraghaApplication pragha) { PraghaPlaylist playlist; playlist = pragha_application_get_playlist (pragha);

pragha_playlist_set_track_error (playlist, pragha_backend_get_error (backend));

/*

• Don't show error dialog if the playback of the currupted file
• is not started by user explicitly */ if (pragha_playlist_get_implicit_track(playlist)) { pragha_playlist_go_next_track (playlist); return; } else { gui_backend_error_show_dialog_cb (backend, error, pragha); }

} `

[matiasdelellis]

Hi @np2048 Many apologies for never answering this pull-request . . :disappointed:

Of course, thank you very much for this!. :grimacing:

However, although it seemed an interesting approach, I finally preferred to add an option to the dialog to ignore the errors, for all songs equally, but optionally..

Please, see last commit on master.

• https://github.com/pragha-music-player/pragha/commit/31813a55122df603dac2de4a779a0fd833133026

Again, Thanks you!. :smile: Regards, Matias.