Closed darkshram closed 4 years ago
Hi @darkshram I like the changes, except the translations that must be done by gettext and transifex. :wink:
Do you want to try? :grimacing:
I'll try in a few days. I have a little tight schedule. io.github.pragha_music_player.metainfo.xml will need to be renamed to io.github.pragha_music_player.metainfo.xml.in and to modify Makefile to do the rest. <name>, <summary> and <description>
tags just need to be replaced with <_name>, <_summary> and <_description>
and obviously have an entry in the pot and po files. For the time being, just remove the lines with xml:lang and modify whatever yo need, so pragha's appdata will look awesome in app stores. Appdata will validate Ok with 'appstream-util validate' instead of 'appstream-util validate-strict' (only validate-strict requires <name>, <summary> and <description>
to have translations).
Hi @darkshram Wow, Thank you for answering so quickly. I'm doing the changes form translation with gettex. Wait some minutes. :wink:
Well, Finally I add all your changes in the last master commit. Please when you can, look at it.. :wink:
[matias@ideapad pragha]$ appstream-util validate data/io.github.pragha_music_player.metainfo.xml
data/io.github.pragha_music_player.metainfo.xml: OK
But in strict mode fail due intool remove the copyright comment.. :confused:
[matias@ideapad pragha]$ appstream-util validate-strict data/io.github.pragha_music_player.metainfo.xml
data/io.github.pragha_music_player.metainfo.xml: FAILED:
• value-missing : <!-- Copyright [year] [name] --> is not present
Validation of files failed
p.s: It's a shame that will not be properly registered -As git commit authored- that these are your changes.. Sorry.. :disappointed:
p.s: It's a shame that will not be properly registered -As git commit authored- that these are your changes.. Sorry.. disappointed
Don't worry. The goal was to improve visibility of pragha in app stores.
Keywords may be localized too. I would recommend to add 'player'.
<keywords>
<_keyword>audio</keyword>
<_keyword>multimedia</keyword>
<_keyword>player</keyword>
</keywords>
If you add 'Keywords' key to the desktop file too, you may reuse localizations.
[Desktop Entry]
Version=1.0
Type=Application
Name=Pragha
_GenericName=Music Player
_Comment=Manage and listen your music
Icon=pragha
Categories=GTK;AudioVideo;Player;
_Keywords=audio;multimedia;player;
Exec=pragha %F
TryExec=pragha
Terminal=false
StartupNotify=true
MimeType=application/x-ape;audio/ape;audio/x-ape;audio/x-m4a;video/x-ms-asf;audio/x-ms-wma;audio/x-mp3;audio/mpeg;audio/x-mpeg;audio/mpeg3;audio/mp3;application/ogg;application/x-ogg;audio/vorbis;audio/x-vorbis;audio/ogg;audio/x-ogg;audio/x-flac;application/x-flac;audio/flac;audio/x-wav;audio/mpegurl;audio/x-mpegurl;audio/x-scpls;application/xspf+xml;audio/x-ms-wax;
Done.. :grimacing: Thanks!.
Modified appdata file to pass full validation with 'appstream-util validate-strict'.
Before:
After: