pragha-music-player / pragha

Pragha is a Lightweight Music Player for GNU/Linux.
GNU General Public License v3.0
174 stars 35 forks source link

Fetch cover problem #28

Open LazyKent opened 12 years ago

LazyKent commented 12 years ago

Pragha built against libglyr. Plaing the "Stones Grow Her Name" album by "Sonata Arctica". Pragha doesn't fetch the album cover.

screen: http://itmages.ru/image/view/538870/fab82e44

Then I run glyrc.

% glyrc cover -a "Sonata Arctica" -b "Stones Grow Her Name"

---- Triggering: musictree local lastfm ---- Triggering: jamendo musicbrainz slothradio

[00/01] Checking image-types: [.](-0 item%28s%29 less)


///// ITEM #1 ///// WRITE to './Sonata Arctica_Stones Grow Her Name__cover_1.jpeg' FROM: http://ecx.images-amazon.com/images/I/61L-BIv6tTL.jpg PROV: musicbrainz SIZE: 85980 Bytes MSUM: 8d3ca4c84a54b448621e53a143426169 TYPE: cover SAFE: No RATE: 0 STMP: 0,000000 FRMT: jpeg DATA:

////////////////////

=> 1 item in total.

% ll Sonata\ Arctica_Stones\ Grow\ Her\ Namecover_1.jpeg -rw-r--r-- 1 kent users 85980 июня 2 00:32 Sonata Arctica_Stones Grow Her Namecover_1.jpeg

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/3327699-fetch-cover-problem?utm_campaign=plugin&utm_content=tracker%2F352350&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F352350&utm_medium=issues&utm_source=github).
matiasdelellis commented 12 years ago

Yes. Sorry.. Now, only searches in lastfm, because I think that with it get better results. Particularly had problems with some services, that return fictitious covers (or a photo of the artist) when the name of the album was "unknown" for example (Or any strange name).

I suppose that amazon also gives good results, but really do not investigate what were the services that failed. We could do a couple of tests to enable other services.

Pending task to next week!. =)

Thanks for report!. Regards.

LazyKent commented 12 years ago

I'd really like to have a possibility to add/replace a cover manually. Maybe, give us a choice? Sometimes it got wrong results (especially for Russian (my case) music).

Any way, thanks for your work!

openSUSE Pragha packages maintainer

matiasdelellis commented 12 years ago

I'd really like to have a possibility to add/replace a cover manually. Maybe, give us a choice?

I will do in a short time. Surely from a popup menu to open a gtk-filchooser to select the file. Regards.

matiasdelellis commented 12 years ago

Hi LazyKent, I promise all these changes to Pragha 1.1.1, but meanwhile replace the line 353 of glyr-related.c

glyr_opt_from(&glyr_info->query, "lastfm");

by

glyr_opt_from(&glyr_info->query, "lastfm;musicbrainz");

And so, also search in MusicBrainz

LazyKent commented 11 years ago

I'm sorry. Pragha still doesn't fetch covers well.

The screenshot shows everything: pragha-covers

matiasdelellis commented 11 years ago

Please.. Wrote tags (artist, album) of this song to do some tests. ;)

LazyKent commented 11 years ago

There are the tags: http://susepaste.org/view/simple/89133710

matiasdelellis commented 11 years ago

:( Well.. I can not even download it by command line. The best thing I did is forcing the language to Russian. (It seems that lastfm not sharing anithing internationally), but also not download. Using the simple command (With out forcing lastfm or Rusian): glyrc cover --artist "Кипелов и Маврин" --album "Cмутное время" Download it: http://popsa.info/bio/066/97210s.jpg, from picsearch (That in pragha is not activated due to bad responces) but is a corruped file.

Is strange. Later continue investigating..

LazyKent commented 11 years ago

I test using Spanish. % glyrc cover -a "Кипелов и Маврин" -b "Смутное время" -l es -v4

There is the result: http://susepaste.org/view/simple/72731899 And a cover is fetched.

LazyKent commented 11 years ago

I forgot to say. glyr is version 1.0.0