pragha-music-player / pragha

Pragha is a Lightweight Music Player for GNU/Linux.
GNU General Public License v3.0
178 stars 35 forks source link

Compilation error for i586 (Pragha 1.1.0) #31

Closed LazyKent closed 12 years ago

LazyKent commented 12 years ago

Compilation failed for i586:

Making all in src make[2]: Entering directory `/home/abuild/rpmbuild/BUILD/pragha-1.1.0/src' CC pragha-cdda.o CC pragha-cmdline.o CC pragha-current-playlist.o CC pragha-db.o CC pragha-dbus.o CC pragha-filetree.o CC pragha-gui.o CC pragha-glyr-related.o CC pragha-init.o CC pragha-info-bar-import-music.o init.c: In function 'init_config': init.c:1002:12: error: cannot convert to a pointer type make[2]: *\ [pragha-init.o] Error 1

For x86_64 it's OK.

ghost commented 12 years ago

Can you try this patch?

diff --git a/src/pragha.h b/src/pragha.h
--- a/src/pragha.h
+++ b/src/pragha.h
@@ -94,13 +94,13 @@

 /* Some default preferences. */

-#define MIN_WINDOW_WIDTH           0.75 * gdk_screen_width()
-#define MIN_WINDOW_HEIGHT          0.75 * gdk_screen_height()
+#define MIN_WINDOW_WIDTH           (gdk_screen_width() * 3 / 4)
+#define MIN_WINDOW_HEIGHT          (gdk_screen_height() * 3 / 4)
 #define DEFAULT_SIDEBAR_SIZE       200
 #define ALBUM_ART_SIZE             36
 #define PROGRESS_BAR_WIDTH         300
 #define COL_WIDTH_THRESH           30
-#define DEFAULT_PLAYLIST_COL_WIDTH (MIN_WINDOW_WIDTH - DEFAULT_SIDEBAR_SIZE) / 4
+#define DEFAULT_PLAYLIST_COL_WIDTH ((MIN_WINDOW_WIDTH - DEFAULT_SIDEBAR_SIZE) / 4)
 #define OSD_TIMEOUT                5000
 #define ALBUM_ART_PATTERN_LEN      1024
 #define ALBUM_ART_NO_PATTERNS      6
LazyKent commented 12 years ago

The patch helps. Thanks.