"Replace and play" broken

[ghost]

"Replace and play" broken in commit 378db7d1197778fcb6d00f671466eba8b86d7ed3

[matiasdelellis]

In what conditions? I'm testing the final merge and here works..

[ghost]

Now it's only in stopped state.

console output: (pragha:8089): Gtk-CRITICAL **: gtk_tree_row_reference_new: assertion `path != NULL' failed

(pragha:8089): Gtk-CRITICAL **: gtk_tree_model_get_iter: assertion `path != NULL' failed

(pragha:8089): Gtk-CRITICAL **: gtk_tree_model_get_iter: assertion `path != NULL' failed

(pragha:8089): pragha-CRITICAL **: Dangling entry in current playlist

[matiasdelellis]

Your change is correct. had tested stopped and playing, but not paused.

The console output was before your change? I can not reproduce it here.

[ghost]

Can be closed the bug then?

No. I mean it still broken in stopped state.

[matiasdelellis]

:S The only console ouput here is:

(pragha:2857): Gtk-CRITICAL _: IA__gtk_tree_view_scroll_to_cell: assertion `tree_view->priv->model != NULL' failed (pragha:2857): Gtk-CRITICAL _: IA__gtk_tree_model_get_iter_first: assertion `GTK_IS_TREE_MODEL (tree_model)' failed

, when adds radios, but it is due to something else.

When you only replace the playlist, it says the same thing?

[ghost]

For replace there is no console output... but after replace play button doesn't work and triggers the same output as I posted before.

[matiasdelellis]

mm.. When replace, or replace and play, always is selected the same song?. This seems that add a wrong song, and pragha tries to reproduce it. Try playing the selected song, whit enter, or otherwise.

[ghost]

When replace, or replace and play, always is selected the same song?.

Different tracks, albums, artists or whole collection. It doesn't matter.

Try playing the selected song, whit enter, or otherwise.

Double click on track works fine :3

[ghost]

@matiasdelellis Is shuffle enabled? Try disable...

[matiasdelellis]

Yes!!! !. =) (Is comic. I am glad that something is wrong!.)

So, in resume... Steps to reproduce the error:

• Playback stoped and shuffle disabled.
• Replace playlist and play, from library popup.

Results in console output:

(pragha:8089): Gtk-CRITICAL _: gtk_tree_row_reference_new: assertion `path != NULL' failed (pragha:8089): Gtk-CRITICAL _: gtk_tree_model_get_iter: assertion path != NULL' failed (pragha:8089): Gtk-CRITICAL **: gtk_tree_model_get_iter: assertionpath != NULL' failed (pragha:8089): pragha-CRITICAL **: Dangling entry in current playlist

And never play any song.

Well, In the afternoon investigate. but I think know where the problem comes.

Regards.

[ghost]

Also note it plays only the last track if we replace&play on playlist >:3

[matiasdelellis]

Yes, But this is due that when replace by a playlists or radio, the last song is selected automatically. This behavior (Select the last song added) is useful only when you add more songs (and to see what songs added). Not is useful if you replace the entire playlist.

We must review this behavior.

• Select the last song, (or the first added), when you add songs.
• Select the first (or any) when replacing the playlist.

Would be OK?

[ghost]

OK.

[matiasdelellis]

Well, When you have time look at the branch SelectReplaceAddBehavior.

• When add songs to current playlist, always select first song added.
• But when replace the playlist: If shufle is activated, not select anyting, to play a random song, and if shuffle is disabled, always select the first song.

[ghost]

Looks working.

[matiasdelellis]

Well, merge and close it?.

[ghost]

Sure.