pragha-music-player / pragha

Pragha is a Lightweight Music Player for GNU/Linux.
GNU General Public License v3.0
178 stars 35 forks source link

need a way to deal with bad lyrics #61

Open ghost opened 10 years ago

ghost commented 10 years ago

It happens. Manually deleting the whole cache is not nice.

Maybe something like: -Try other providers (how hard would be to implement?) -Try again (after updating glyr) -Delete from cache (so next play it gets re-downloaded)

Also, any ideas how to expose this in GUI?

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/2172918-need-a-way-to-deal-with-bad-lyrics?utm_campaign=plugin&utm_content=tracker%2F352350&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F352350&utm_medium=issues&utm_source=github).
matiasdelellis commented 10 years ago

Hi, Is one of the pending tasks.

Maybe adding a button, [Find more Lyrics..] Immediately once that found all the lyrics, show the dialog with a button [OK] [Next]

Glyr can download many lyrics, but can not do it by default to save time.

Other pending thing is the editing ... Because there are definitely lyrics that I will never find on the Internet..

matiasdelellis commented 10 years ago

Hi Pavel, Test the last commit, Still not save the selection, but more or less is the idea. It's what you expect?.

matiasdelellis commented 10 years ago

Revert the commit on master, and open a new branch https://github.com/matiasdelellis/pragha/tree/MoreSearchsGlyr

Now can save the selection, but sometimes break Pragha. And can not discover why... :S

ghost commented 10 years ago

Still not save the selection, but more or less is the idea. It's what you expect?.

Yeah something like this

smarquespt commented 10 years ago

This could be a nonsense question but how do I search for lyrics?

matiasdelellis commented 10 years ago

Hi,

This could be a nonsense question but how do I search for lyrics?

Talk about Pragha 1.3 with plugins (Need libpeas) and lyrics (Need libglyr) enabled on build..?

In playlist: Right click on song > Tools > Search lyrics In window: (Only to show current song lyrics): Main menu > View > Secondary lateral panel.

But the bug relates to another problem, when can not find the song, Glyr save that not found the song and next time not even search.. When providers may probably added the song.

Whell, The branch MoreSearchGlyr try to fix it ading a option in the Lyrics panel called "Search in other providers". But it not working properly yet.

smarquespt commented 10 years ago

I know that issue is about different thing. I just thought that there was no need to open a (non) issue.

Anyway, I have 1.3 but on windows. Windows release doesn´t have both options that you mentioned.

matiasdelellis commented 10 years ago

I just thought that there was no need to open a (non) issue.

:+1:

Anyway, I have 1.3 but on windows. Windows release doesn´t have both options that you mentioned.

Ohh. First user who uses it!. Thank you!.

In windows not yet support any plugin. I tried to compile libpeas in mingw but has many dependencies (libglyr is much easier..) When compile libpeas, add the plugins will be easier.

Regards.