pragha-music-player / pragha

Pragha is a Lightweight Music Player for GNU/Linux.
GNU General Public License v3.0
173 stars 35 forks source link

"Playlist -> Add location" adds only the first item of an m3u playlist #81

Closed yurkobb closed 8 years ago

yurkobb commented 9 years ago

In many cases (like archive.org for example), sites provide a "stream URL" pointing to an m3u playlist that contains more URI's than just one (example, another one). Typically this is a way to stream an entire album to a player. Currently Pragha only adds the first song in the playlist and ignores the rest. It should add all the songs in the m3u file instead.

matiasdelellis commented 9 years ago

Hi, You refers to menu "Playlist-> Add location"? You're right, but this is because it is thought to radios. The idea was to add only a radio to the lateral penel. Not for playlist.. :worried:

I would like to fix, :wink: The problem is how to correctly differentiate radio and playlists without complicating the interface.

What do you suggest?. How other players behave?.

Regards, Thank you for participating, Matias

yurkobb commented 9 years ago

Thanks for your reply, Matias! Regarding the differentiation between radio and playlist - to me as a user the most natural place for a collection of radios would be as a tab in the same place where we have the library browser now (on the left). So that one would switch between browsing radios and local files on the left.

But the current functionality of "Playlist -> Add location" clearly suggests that we add something to the playlist, not to some collection of radios (bookmarks?), unrelated do the playlist.

So I'd suggest that if the user adds an m3u URL to the the playlist, we parse it and add all the tracks that are inside into the playlist. If it is an internet radio, most likely it will contain only one track (i.e. stream), so nothing will change for the user in the case of radio.

But if the m3u URL has multiple tracks, then it is not a radio, but probably something like an album. So in both cases it makes sense to just add to the playlist the amount of tracks that is available in the m3u file (this is what VLC does by the way).

And thanks for your hard word:)

Yury

matiasdelellis commented 9 years ago

Hi Yury, I hope the last commit meet your expectations.. :smile:

In summary:

This last point is just what we wanted to avoid, but I think for now it is enough.. :relieved:

Please, Test it. Regards, Matias.

yurkobb commented 8 years ago

Works perfectly:) Thanks man.

matiasdelellis commented 8 years ago

Ok. So fixed on Pragha v1.3.3

Regards, :wink: