search

pragha-music-player / pragha

Pragha is a Lightweight Music Player for GNU/Linux.
GNU General Public License v3.0
178 stars 35 forks source link

Last.fm suggested a tag correction for Russian tags #93

Closed LazyKent closed 6 years ago

LazyKent commented 8 years ago

Last.fm suggested a tag correction for Russian tags.

And it looks very strange: http://susepaste.org/view/simple/39258450

The tags are OK: http://susepaste.org/view/simple/76559656

Not seen with OGG files only. The same with MP3: http://susepaste.org/view/simple/56311010

Is this something wrong in libclastfm or in Pragha itself?

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29088612-last-fm-suggested-a-tag-correction-for-russian-tags?utm_campaign=plugin&utm_content=tracker%2F352350&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F352350&utm_medium=issues&utm_source=github).
matiasdelellis commented 8 years ago

Hi @LazyKent Sorry the delay in answering.

Last.fm suggested a tag correction for Russian tags.

Surely this is a mistake of the library managing utf8/unicode.. Please send me the tags of an entire song to do some tests..

LazyKent commented 8 years ago

Hello. The tags are:

Album                                    : Откровение
Track name                               : Танец с саблями
Track name/Position                      : 02
Performer                                : Валерий Ковтун
Genre                                    : Instrumental
Recorded date                            : 2007
matiasdelellis commented 8 years ago

Hi, Just can reproduce the bug .. Now I do a couple of tests ..;)

p.d: Mabybe related to https://github.com/pragha-music-player/pragha/issues/28 ?

matiasdelellis commented 8 years ago

Hi @LazyKent, Seems to be an error on last.fm API.. The error appears whenever that send characters outside the ASCII.. Not only in Russian, also with accents in Spanish..

I Still not yet discover the encoding used by lastfm to return data..

matiasdelellis commented 6 years ago

Still today I do not see how to solve this .. .. :disappointed:

matiasdelellis commented 6 years ago

Hi @LazyKent If you feel like completing the Russian alphabet, welcome ... :wink:

ps.: Far from being efficient, at least it is only used in a thread separated from the main one.. :sweat_smile: EDIT: PS: See last commit.. :wink:

LazyKent commented 6 years ago

At the moment I don't see any warnings from Last.fm to Russian tags. Probably, fixed there. Closed.