search

pragmagic / godot-nim

Nim bindings for Godot Engine
https://pragmagic.github.io/godot-nim/
Other
497 stars 27 forks source link

Change VariantType to workaround compiler issue #95

Closed jyapayne closed 3 years ago

jyapayne commented 3 years ago

Workaround for: https://github.com/nim-lang/Nim/issues/16462.

It doesn't hurt to change these since it's an internal enum. This makes this repo work with the latest Nim devel.

endragor commented 3 years ago

Thanks for the PR, but the enum is not private - it's re-exported from variants.nim.

And even without that godotinternal module is a part of the public API. It just separates stuff that you should use only when you know what you are doing. But there are useful application use cases for it.

jyapayne commented 3 years ago

Ah, I see. Alright, guess it's better to wait for the compiler to be fixed.

jyapayne commented 3 years ago

@endragor actually, this can be worked around by moving the template below importing of the arrays module. Do you mind if template definePoolArray is moved below import arrays in godot/core/poolarrays.nim?