search

pragmagic / vscode-nim

An extension for VS Code which provides support for the Nim language.
Other
235 stars 38 forks source link

Add Nim file icon #54

Open hcorion opened 7 years ago

hcorion commented 7 years ago

With the new version of Visual Studio Code, there are icons for each filetype, but not for Nim. I would appreciate an icon for Nim files (Just the Nim crown would be good). Some documentation is here: https://github.com/Microsoft/vscode/issues/10804

kosz78 commented 7 years ago

To add icon for file type it is required add it for each theme separatelly, the VSCode Icons theme already support Nim icons

The default VSCode Seti theme doesnt support Nim icon yet, to add icon it is required creature pull request according this instruction https://github.com/Microsoft/vscode/blob/master/extensions/theme-seti/icons/vs-seti-icon-theme.json

dom96 commented 7 years ago

Wow, those icons look amazingly bad with the default theme. And the black/gold Nim crown looks bad too, I switched back to default :\

zolomatok commented 4 years ago

@hcorion @dom96 I added a PR with the Nim icon for the default VSC icon set. https://github.com/jesseweed/seti-ui/pull/579

That icons set uses only 9 curated colors for all icons (so that they look nice with one another). There was only one yellow color, so I selected that.