search

pragmagic / vscode-nim

An extension for VS Code which provides support for the Nim language.
Other
237 stars 37 forks source link

in devel changed new line behavior results in not working linting #77

Closed RSDuck closed 6 years ago

RSDuck commented 6 years ago

Since https://github.com/nim-lang/Nim/commit/80caca15bd72e5dbc2712c1f0f6cbfa90262fbb2 \n results in a single line feed character and not in the platform specific new line character anymore. Therefore the os.EOL in https://github.com/pragmagic/vscode-nim/blob/124c8848a55fb73e2a2dc75bb842859b6752b96a/src/nimBuild.ts#L60 isn't splitting the(now by single line feeds seperated) text on Windows anymore, which breaks the linting using nim check.

For compability the best thing would probably be to split both by os.EOL and \n if os.EOL != \n. What do you think about this?

kosz78 commented 6 years ago

Good suggestion, thank you

kosz78 commented 6 years ago

Fixed by #78