search

pragmagic / vscode-nim

An extension for VS Code which provides support for the Nim language.
Other
237 stars 37 forks source link

getBinPath getting the wrong path and ignore any error pretend get the path #92

Closed bung87 closed 5 years ago

bung87 commented 5 years ago

https://github.com/pragmagic/vscode-nim/blob/d708f9b41387aa784c765044704d5d8153e80c90/src/nimUtils.ts#L94

the code above will get the first file or dir or symbollink in $PATH which contains nim,and then readlink will fail if it is not a symbollink, I will make PR for this,think using which command would be more generic.