pragnagopa / BreakingChangeAnalysisHelpers

0 stars 0 forks source link

Errors that are safe to ignore #5

Open pragnagopa opened 4 years ago

pragnagopa commented 4 years ago

Tracking issue to list errors that are safe to ignore.

For the following error :

Removed - microsoft.extensions.configuration - M:Microsoft.Extensions.Configuration.ConfigurationSection.#ctor(Microsoft.Extensions.Configuration.ConfigurationRoot,System.String)

in 3.1

ConfigurationSection(IConfigurationRoot, String)

in 2.2

ConfigurationSection(ConfigurationRoot, String)

This should continue to work as ConfigurationRoot implements IConfigurationRoot in 2.2 and 3.1

https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.configuration.configurationroot?view=dotnet-plat-ext-2.2

https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.configuration.configurationroot?view=dotnet-plat-ext-3.1

cc @fabiocav

pragnagopa commented 4 years ago

Following error:

Removed - microsoft.aspnetcore.mvc.formatters.json - M:Microsoft.AspNetCore.Mvc.JsonResult.#ctor(System.Object,Newtonsoft.Json.JsonSerializerSettings)

in 3.1

public JsonResult (object value, object serializerSettings);

in 2.2

public JsonResult (object value, Newtonsoft.Json.JsonSerializerSettings serializerSettings);

should continue to work as passing Newtonsoft.Json.JsonSerializerSettings as object is safe

Following error:

Removed - microsoft.aspnetcore.mvc.formatters.json - M:Microsoft.AspNetCore.Mvc.JsonResult.set_SerializerSettings(Newtonsoft.Json.JsonSerializerSettings)

in 3.1

public object SerializerSettings { get; set; }

in 2.2

public Newtonsoft.Json.JsonSerializerSettings SerializerSettings { get; set; }

should continue to work as setting Newtonsoft.Json.JsonSerializerSettings to object is safe

pragnagopa commented 4 years ago

Error:

ChangedBaseClass - microsoft.aspnetcore.mvc.viewfeatures - T:Microsoft.AspNetCore.Mvc.RemoteAttribute

in 3.1

public class RemoteAttribute : Microsoft.AspNetCore.Mvc.RemoteAttributeBase

in 2.2

public class RemoteAttribute : System.ComponentModel.DataAnnotations.ValidationAttribute, Microsoft.AspNetCore.Mvc.ModelBinding.Validation.IClientModelValidator

should continue to work as RemoteAttributeBase implements System.ComponentModel.DataAnnotations.ValidationAttribute, Microsoft.AspNetCore.Mvc.ModelBinding.Validation.IClientModelValidator