Closed calebmauer closed 8 years ago
Hey @calebmauer
Thanks a lot for refactoring this code, I'd been meaning to do this myself since a while but was unable to take the time to do so. I just have a few queries regarding the changes you made:
document.getElementById("fieldName").focus();
(on line 56 of assets/partials/addTableDialog.html) ?style
tag on line 217
?height: 100vh;
to body and similar attributes to the #theCanvas object in app.css. What does this do (I'm not that great at CSS myself).Finally, I hope you have tested the app thoroughly before submitting this PR?
Yep, I tested this all thoroughly. :)
On Sat, Jun 18, 2016 at 9:01 PM, Prahlad Yeri notifications@github.com wrote:
Hey @calebmauer https://github.com/calebmauer
Thanks a lot for refactoring this code, I'd been meaning to do this myself since a while but was unable to take the time to do so. I just have a few queries regarding the changes you made:
- Why did you remove document.getElementById("fieldName").focus(); (on line 56 of assets/partials/addTableDialog.html) ?
- Similarly, the style tag on line 217 ?
- I see that you have added height: 100vh; to body and similar attributes to the #theCanvas object in app.css. What does this do (I'm not that great at CSS myself).
Finally, I hope you have tested the app thoroughly before submitting this PR?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/prahladyeri/VisualAlchemist/pull/32#issuecomment-226973437, or mute the thread https://github.com/notifications/unsubscribe/ABc2-4wdgBb3_E76XNbOu2TJG-dP55gnks5qNJTlgaJpZM4I380u .
@calebmauer Thanks for your contribution. Please note that as mentioned in contributor guidelines, this is a GPLv3 project, so please make sure that all your contributed code complies accordingly.
I'm pretty sure they do. The only code I don't come up with on my own is maybe stuff from Stack Overflow but if I copy code directly from Stack Overflow I will add a comment with the URL of the post I got it from.
On Sat, Jun 18, 2016 at 10:15 PM, Prahlad Yeri notifications@github.com wrote:
@calebmauer https://github.com/calebmauer Thanks for your contribution. Please note that as mentioned in contributor guidelines, this is a GPLv3 project, so please make sure that all your contributed code complies accordingly.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/prahladyeri/VisualAlchemist/pull/32#issuecomment-226975376, or mute the thread https://github.com/notifications/unsubscribe/ABc2--w-o4S8oZ9jEAwnpVysHxLnCKJOks5qNKYzgaJpZM4I380u .
Perfect!
Fixed commas in details column to not have double commas or having a comma when there is only one thing in the details row. Edited error messages to be more descriptive. Changed error messages to use bspopup instead of alert. Moved embedded css into app.css. Shortened and cleaned up code in app.js addTable section.