prairiedogbeer
commented
7 years ago I fixed this by creating a new DataSourceError exception type that all firebase-related errors, including a new DSConnectionError class, inherit from. I changed the firebase handle creation code to catch the same exceptions as the get and set code, which is working well, and raise the DSConnectionError in that event. Then I updated the _log_state code to catch all DataSourceError types and handle them gracefully (with a log message).
I recently changed the code to handle HTTPError and SSLError exceptions by nulling the firebase handle so that a new connection would be established, but the code for the initial firebase database connection is not properly trapping those errors and handling them gracefully, terminating threads.
Examples of errors:
As you can see, the error is properly handled at the DampenedBeer level, meaning the exception was caught and dealt with by nulling the handle. Four seconds later, the _log_state code in manager.py tries to use the handle, which results in a connection attempt for a new handle, but the requests HTTPError is raised and unhandled, terminating the thread.