search

praiskup / argparse-manpage

Automatically build man-pages for your Python project
Apache License 2.0
41 stars 22 forks source link

Preserve the environment when running pip or setup.py from within the tests #39

Closed hroncok closed 2 years ago

hroncok commented 2 years ago

Whatever I try, the CI won't start for me here.

Nevertheless, a local rawhide and f35 mock builds passed for me. It fails on f34 or lower because --in-tree-build is a new option of pip.

I also heavily suggest running subprocess with check=True, so you get the failure when there is one instead of a failed assertion later.

praiskup commented 2 years ago

I suppose I can not trigger the workflow (for the first-time contributor) here, could that be because of the "Draft" config?

praiskup commented 2 years ago

Ok, you need to switch it against main again, so I can press the button ...

praiskup commented 2 years ago

Ah, I see now ... you applied this against the proposal branch intentionaly, sorry I'm a bit shifted to other stuff already ... :-) thank you for the patch!