Closed stanislavlevin closed 2 years ago
BTW We are working on updating setuptools to 60+ in Rawhide.
Ok, can you confirm that #52 helps?
If you send a Fedora PR with that patch, it will be autotested in the setuptools 60 copr.
@praiskup, for my distro I fixed examples and expected output, but the way is up to you. I left a comment in mentioned PR, thank you.
@hroncok fixed in Fedora Rawhide (I haven't done the build as it doesn't make sense at this point in time I think)
Hi, @praiskup, I've done a build for Fedora Rawhide in the test Copr which failed as no tests were found:
+ cd argparse-manpage-2.2
+ CFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection'
+ LDFLAGS='-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id=sha1 -Wl,-dT,/builddir/build/BUILD/argparse-manpage-2.2/.package_note-argparse-manpage-2.2-1.fc37.x86_64.ld'
+ PATH=/builddir/build/BUILDROOT/argparse-manpage-2.2-1.fc37.x86_64/usr/bin:/builddir/.local/bin:/builddir/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
+ PYTHONPATH=/builddir/build/BUILDROOT/argparse-manpage-2.2-1.fc37.x86_64/usr/lib64/python3.10/site-packages:/builddir/build/BUILDROOT/argparse-manpage-2.2-1.fc37.x86_64/usr/lib/python3.10/site-packages
+ PYTHONDONTWRITEBYTECODE=1
+ PYTEST_ADDOPTS=' --ignore=/builddir/build/BUILD/argparse-manpage-2.2/.pyproject-builddir'
+ /usr/bin/pytest
============================= test session starts ==============================
platform linux -- Python 3.10.2, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
rootdir: /builddir/build/BUILD/argparse-manpage-2.2
collected 0 items
============================ no tests ran in 0.02s =============================
error: Bad exit status from /var/tmp/rpm-tmp.S1GW5O (%check)
Bad exit status from /var/tmp/rpm-tmp.S1GW5O (%check)
Thanks for the ping, the release tarball was incomplete, fixed by: 1c9418e80833bc616e6a43edacc0ba7cc70aab1b New tarball was uploaded to fedora lookaside cache.
@praiskup, thank you, this time the build is green as cucumber :)
As of 60 setuptools once again switched stdlib's distutils to its own copy:
https://docs.python.org/3/whatsnew/3.10.html#distutils-deprecated https://setuptools.pypa.io/en/latest/history.html#v60-0-0
With this change 2 tests fails as:
Version is defined as
distribution.get_version()
: https://github.com/praiskup/argparse-manpage/blob/abe59c085961865a2ceb91f376ac9da9d83ffccd/build_manpages/build_manpage.py#L97-L101stdlib's distutils passes version from metainfo as is, while setuptools' one normalizes it: https://github.com/pypa/setuptools/blob/5e94859bf197500e6953c90668eb4cee159d25cf/setuptools/dist.py#L470-L472
Probably, normalized versions should be provided for tests to be compatible with either setuptools.