search

praiskup / argparse-manpage

Automatically build man-pages for your Python project
Apache License 2.0
41 stars 22 forks source link

Unify inputs from CLI and setup.cfg + additional fixes #53

Closed dmach closed 2 years ago

praiskup commented 2 years ago

Can you please add a test-case (examples subdirectory)?

dmach commented 2 years ago

I've ended up modifying the current test cases in the end, no new test cases are needed (yet). Please take a look if the changes don't break any of your expectations from the manpage generation.

praiskup commented 2 years ago

Can you add a NEWS entry, please?

praiskup commented 2 years ago

Seems like some of those issues are fixed, but not pushed here?

praiskup commented 2 years ago

Gently ping, @dmach?

dmach commented 2 years ago

@praiskup I finally returned back to finishing this. Could you take a look?

praiskup commented 2 years ago

the test failures are mostly related to https://bugzilla.redhat.com/show_bug.cgi?id=2026979 :-(

praiskup commented 2 years ago

Please rebase, the tests should be fixed.

praiskup commented 2 years ago

Otherwise +1

praiskup commented 2 years ago

And thank you!

praiskup commented 2 years ago

Ok, LGTM anyway. I'm going to merge this in #56, review there would be welcome!